Added support for Service Account authentication#34
Open
LukevdPalen wants to merge 5 commits intoChrisAlvares:masterfrom
Open
Added support for Service Account authentication#34LukevdPalen wants to merge 5 commits intoChrisAlvares:masterfrom
LukevdPalen wants to merge 5 commits intoChrisAlvares:masterfrom
Conversation
* 'master' of github.com:ChrisAlvares/node-adwords: updated API to version 201710 bumped version. updated readme to fix ChrisAlvares#48 updated packages. updated version of api to v201708 updated npm libraries added change log updated ad group service to remove bidding strategy type as it is not valid anymore. updates apis to 201705 added prompt to be conset to generate a new access token on every auth url. updated version. Removed note about versioning. Updated readme
|
Any chance of getting this merged, 1 year later? |
|
This feature would be very helpful for my use. Any update on this being merged? |
* 'master' of github.com:ChrisAlvares/node-adwords: case where oauth error is in body and report.format is xml updated adwords to use v201806 updated changelog. version bumped. updated package lock file. updated dependencies Updates googleapis and request to their latest versions, which depend on newer versions of hoek that don't have security vulnerabilities. bumped version. adds the offline data upload service. updated packages. updated to adwords 201802 Bump soap package to latest
* 'master' of github.com:ChrisAlvares/node-adwords: version bumped removed forEach from service and users. updated change log update report builder to not use for loops. adds support for v201809 fix: duplicate key Using google-auth-library instead of googleapi package # Conflicts: # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes allow the use of other oAuth mechanismes like JWT (Service Tokens). Services and Reports are not longer responsble for constucting the
oAuth2Clientthey receive it as an argument like it's done in het Python library. https://github.com/googleads/googleads-python-lib/blob/master/googleads/adwords.py#L192 Constucting the oAuth2Client is done byuser.js,client.jsorauth.js, this makes is more flexibele.All changes are backward compatible.